fix: align S3 static-website tutorial with sample, fix bucket name and output discrepancies#495
Merged
quetzalliwrites merged 3 commits intomainfrom Apr 27, 2026
Merged
Conversation
HarshCasper
requested review from
quetzalliwrites and
remotesynth
as code owners
Deploying localstack-docs with
|
| Latest commit: |
d946568
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e5f43db1.localstack-docs.pages.dev |
| Branch Preview URL: | https://harshmishra-doc-113.localstack-docs.pages.dev |
remotesynth
approved these changes
Mar 16, 2026
mmaureenliu
reviewed
Mar 20, 2026
| We can do this by specifying the `endpoints` parameter for each service, that we intend to use. | ||
| We can do this by specifying the `endpoints` parameter for each service that we intend to use. | ||
|
|
||
| When using LocalStack, set `s3_use_path_style = true` so that S3 requests use path-style URLs, which LocalStack expects for the local endpoint. |
There was a problem hiding this comment.
Hi I'm a bit confused here. The original setting of s3_use_path_style = false did work - are you saying true is the more correct setting?
Btw my original reported issue is more the inconsistency between the code examples in our tutorial docs vs that's in our sample repos (e.g. see https://github.com/localstack-samples/localstack-terraform-samples/blob/master/s3-static-website/provider.tf) - it seems to me when we updated tutorial docs the corresponding sample repos is not updated.
Member
Author
There was a problem hiding this comment.
Hi @mmaureenliu, yes — my apologies! false works and matches the original. I have reverted that now. The sample files (outputs.tf, provider.tf) have now been updated to match the docs.
HarshCasper
changed the title
quetzalliwrites
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes DOC-113
Related PR: localstack-samples/localstack-terraform-samples#15
Summary
www/subdirectory (matches sample).awslocal s3 sync ./www/replacesawslocal s3 sync ./sobucket_policy.jsonno longer gets uploaded into the bucket.main.tfusesfileset("${path.root}", "www/*.html")to match the sample.testwebsitethroughout — the terraformapplyexample previously usedtestbucket, which silently broke every command in the Testing section.outputs.tfnow prints LocalStack-formatteddomainandwebsite_endpointso users get an openable URL, instead of the misleading AWS-formatted strings (*.s3-website-us-east-1.amazonaws.com) returned by theaws_s3_bucket_website_configurationattributes.#s3_force_path_style→#s3_use_path_style; addeds3controlendpoint (required by AWS provider v6 to read bucket tags) with an explanatory note.s3_use_path_style = falseretained.